Skip to content

src: improve error handling in cares_wrap #57937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

src: improve error handling in cares_wrap #57937

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 19, 2025 •
edited
Loading

Improve error handling in cares_wrap by replacing ToLocalChecked() and Check() calls.
Reduce some code duplication using macros

@jasnell jasnell requested review from anonrig and aduh95 April 19, 2025 22:16
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Apr 19, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 19, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/66373/ 💛

@codecov Codecov
Copy link

codecov bot commented Apr 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.94309% with 325 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (25842c5) to head (d1771d9).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
src/cares_wrap.cc 34.08% 246 Missing and 77 partials ⚠️
src/cares_wrap.h 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57937      +/-   ##
==========================================
- Coverage   92.26%   90.19%   -2.07%     
==========================================
  Files         325      630     +305     
  Lines      126673   186174   +59501     
  Branches    20783    36562   +15779     
==========================================
+ Hits       116869   167923   +51054     
- Misses       9576    11066    +1490     
- Partials      228     7185    +6957
Files with missing lines Coverage Δ
src/cares_wrap.h 78.97% <0.00%> (ø)
src/cares_wrap.cc 54.38% <34.08%> (ø)

... and 410 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jasnell added a commit that referenced this pull request Apr 27, 2025
@jasnell
src: improve error handling in cares_wrap
f114dbe 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
jasnell added a commit that referenced this pull request Apr 27, 2025
@jasnell
src: use macros to reduce code duplication is cares_wrap
49bb0ae 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2025

Landed in e716081...49bb0ae

@jasnell jasnell closed this Apr 27, 2025
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@jasnell @RafaelGSS
src: improve error handling in cares_wrap
f0905d3 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@jasnell @RafaelGSS
src: use macros to reduce code duplication is cares_wrap
3e78222 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@jasnell @RafaelGSS
src: improve error handling in cares_wrap
f36d300 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@jasnell @RafaelGSS
src: use macros to reduce code duplication is cares_wrap
4e02f23 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@jasnell @aduh95
src: improve error handling in cares_wrap
480747d 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@jasnell @aduh95
src: use macros to reduce code duplication is cares_wrap
2c7b996 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@jasnell @aduh95
src: improve error handling in cares_wrap
3d1a8a6 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@jasnell @aduh95
src: use macros to reduce code duplication is cares_wrap
809a20d 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@jasnell @RafaelGSS
src: improve error handling in cares_wrap
e461cbc 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@jasnell @RafaelGSS
src: use macros to reduce code duplication is cares_wrap
262e271 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@jasnell @aduh95
src: improve error handling in cares_wrap
7a17de3 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@jasnell @aduh95
src: use macros to reduce code duplication is cares_wrap
fd9f0a9 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jasnell @aduh95
src: improve error handling in cares_wrap
9408ced 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jasnell @aduh95
src: use macros to reduce code duplication is cares_wrap
8b46145 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jasnell @aduh95
src: improve error handling in cares_wrap
9925638 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jasnell @aduh95
src: use macros to reduce code duplication is cares_wrap
94060bb 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jasnell @aduh95
src: improve error handling in cares_wrap
8e9132f 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jasnell @aduh95
src: use macros to reduce code duplication is cares_wrap
4a181da 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@jasnell @aduh95
src: improve error handling in cares_wrap
42caa3b 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@jasnell @aduh95
src: use macros to reduce code duplication is cares_wrap
d6999ab 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@jasnell @aduh95
src: improve error handling in cares_wrap
39af5d6 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@jasnell @aduh95
src: use macros to reduce code duplication is cares_wrap
065e8cd 
PR-URL: #57937
Reviewed-By: Yagiz Nizipli <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasnell @nodejs-github-bot @anonrig